From bcb0007f9a08021a88d8790b947e919560cacf99 Mon Sep 17 00:00:00 2001 From: Moritz Halbritter Date: Thu, 2 Apr 2026 10:59:55 +0200 Subject: [PATCH] Add support for apache/artemis Closes gh-49865 --- ...nectionDetailsFactoryIntegrationTests.java | 9 +++++ ...DockerComposeConnectionDetailsFactory.java | 2 +- .../pages/features/dev-services.adoc | 2 +- ...nectionDetailsFactoryIntegrationTests.java | 4 +-- .../container/ArtemisContainer.java | 32 ++++++++++++++++++ .../container/ArtemisLegacyContainer.java | 33 +++++++++++++++++++ .../boot/testsupport/container/TestImage.java | 9 +++-- .../smoketest/artemis/SampleArtemisTests.java | 4 +-- 8 files changed, 87 insertions(+), 8 deletions(-) create mode 100644 spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/ArtemisContainer.java create mode 100644 spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/ArtemisLegacyContainer.java diff --git a/spring-boot-project/spring-boot-docker-compose/src/dockerTest/java/org/springframework/boot/docker/compose/service/connection/activemq/ArtemisDockerComposeConnectionDetailsFactoryIntegrationTests.java b/spring-boot-project/spring-boot-docker-compose/src/dockerTest/java/org/springframework/boot/docker/compose/service/connection/activemq/ArtemisDockerComposeConnectionDetailsFactoryIntegrationTests.java index 54b75fb28bd..0bac84caa6c 100644 --- a/spring-boot-project/spring-boot-docker-compose/src/dockerTest/java/org/springframework/boot/docker/compose/service/connection/activemq/ArtemisDockerComposeConnectionDetailsFactoryIntegrationTests.java +++ b/spring-boot-project/spring-boot-docker-compose/src/dockerTest/java/org/springframework/boot/docker/compose/service/connection/activemq/ArtemisDockerComposeConnectionDetailsFactoryIntegrationTests.java @@ -27,9 +27,18 @@ import static org.assertj.core.api.Assertions.assertThat; * Integration tests for {@link ArtemisDockerComposeConnectionDetailsFactory}. * * @author Eddú Meléndez + * @author Moritz Halbritter */ class ArtemisDockerComposeConnectionDetailsFactoryIntegrationTests { + @DockerComposeTest(composeFile = "artemis-compose.yaml", image = TestImage.ARTEMIS_LEGACY) + void runCreatesConnectionDetailsWithLegacyImage(ArtemisConnectionDetails connectionDetails) { + assertThat(connectionDetails.getMode()).isEqualTo(ArtemisMode.NATIVE); + assertThat(connectionDetails.getBrokerUrl()).isNotNull().startsWith("tcp://"); + assertThat(connectionDetails.getUser()).isEqualTo("root"); + assertThat(connectionDetails.getPassword()).isEqualTo("secret"); + } + @DockerComposeTest(composeFile = "artemis-compose.yaml", image = TestImage.ARTEMIS) void runCreatesConnectionDetails(ArtemisConnectionDetails connectionDetails) { assertThat(connectionDetails.getMode()).isEqualTo(ArtemisMode.NATIVE); diff --git a/spring-boot-project/spring-boot-docker-compose/src/main/java/org/springframework/boot/docker/compose/service/connection/activemq/ArtemisDockerComposeConnectionDetailsFactory.java b/spring-boot-project/spring-boot-docker-compose/src/main/java/org/springframework/boot/docker/compose/service/connection/activemq/ArtemisDockerComposeConnectionDetailsFactory.java index 1d668c0010d..92194af162d 100644 --- a/spring-boot-project/spring-boot-docker-compose/src/main/java/org/springframework/boot/docker/compose/service/connection/activemq/ArtemisDockerComposeConnectionDetailsFactory.java +++ b/spring-boot-project/spring-boot-docker-compose/src/main/java/org/springframework/boot/docker/compose/service/connection/activemq/ArtemisDockerComposeConnectionDetailsFactory.java @@ -35,7 +35,7 @@ class ArtemisDockerComposeConnectionDetailsFactory private static final int ACTIVEMQ_PORT = 61616; protected ArtemisDockerComposeConnectionDetailsFactory() { - super("apache/activemq-artemis"); + super(new String[] { "apache/activemq-artemis", "apache/artemis" }); } @Override diff --git a/spring-boot-project/spring-boot-docs/src/docs/antora/modules/reference/pages/features/dev-services.adoc b/spring-boot-project/spring-boot-docs/src/docs/antora/modules/reference/pages/features/dev-services.adoc index 002b79c7f68..ad10e433c64 100644 --- a/spring-boot-project/spring-boot-docs/src/docs/antora/modules/reference/pages/features/dev-services.adoc +++ b/spring-boot-project/spring-boot-docs/src/docs/antora/modules/reference/pages/features/dev-services.adoc @@ -87,7 +87,7 @@ The following service connections are currently supported: | Containers named "symptoma/activemq", "apache/activemq-classic" or "apache/activemq" | javadoc:org.springframework.boot.autoconfigure.jms.artemis.ArtemisConnectionDetails[] -| Containers named "apache/activemq-artemis" +| Containers named "apache/activemq-artemis" or "apache/artemis" | javadoc:org.springframework.boot.autoconfigure.cassandra.CassandraConnectionDetails[] | Containers named "cassandra", "bitnami/cassandra" or "bitnamilegacy/cassandra" diff --git a/spring-boot-project/spring-boot-testcontainers/src/dockerTest/java/org/springframework/boot/testcontainers/service/connection/activemq/ArtemisContainerConnectionDetailsFactoryIntegrationTests.java b/spring-boot-project/spring-boot-testcontainers/src/dockerTest/java/org/springframework/boot/testcontainers/service/connection/activemq/ArtemisContainerConnectionDetailsFactoryIntegrationTests.java index ae66a47b8b7..b0d9f55a6e7 100644 --- a/spring-boot-project/spring-boot-testcontainers/src/dockerTest/java/org/springframework/boot/testcontainers/service/connection/activemq/ArtemisContainerConnectionDetailsFactoryIntegrationTests.java +++ b/spring-boot-project/spring-boot-testcontainers/src/dockerTest/java/org/springframework/boot/testcontainers/service/connection/activemq/ArtemisContainerConnectionDetailsFactoryIntegrationTests.java @@ -22,7 +22,6 @@ import java.util.List; import org.awaitility.Awaitility; import org.junit.jupiter.api.Test; -import org.testcontainers.activemq.ArtemisContainer; import org.testcontainers.junit.jupiter.Container; import org.testcontainers.junit.jupiter.Testcontainers; @@ -31,6 +30,7 @@ import org.springframework.boot.autoconfigure.ImportAutoConfiguration; import org.springframework.boot.autoconfigure.jms.JmsAutoConfiguration; import org.springframework.boot.autoconfigure.jms.artemis.ArtemisAutoConfiguration; import org.springframework.boot.testcontainers.service.connection.ServiceConnection; +import org.springframework.boot.testsupport.container.ArtemisLegacyContainer; import org.springframework.boot.testsupport.container.TestImage; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; @@ -51,7 +51,7 @@ class ArtemisContainerConnectionDetailsFactoryIntegrationTests { @Container @ServiceConnection - static final ArtemisContainer artemis = TestImage.container(ArtemisContainer.class); + static final ArtemisLegacyContainer artemis = TestImage.container(ArtemisLegacyContainer.class); @Autowired private JmsMessagingTemplate jmsTemplate; diff --git a/spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/ArtemisContainer.java b/spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/ArtemisContainer.java new file mode 100644 index 00000000000..4e30d5cbf7a --- /dev/null +++ b/spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/ArtemisContainer.java @@ -0,0 +1,32 @@ +/* + * Copyright 2012-present the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.springframework.boot.testsupport.container; + +import org.testcontainers.utility.DockerImageName; + +/** + * An {@link org.testcontainers.activemq.ArtemisContainer} for {@code apache/artemis}. + * + * @author Moritz Halbritter + */ +public final class ArtemisContainer extends org.testcontainers.activemq.ArtemisContainer { + + public ArtemisContainer(DockerImageName dockerImageName) { + super(dockerImageName); + } + +} diff --git a/spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/ArtemisLegacyContainer.java b/spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/ArtemisLegacyContainer.java new file mode 100644 index 00000000000..2edeeb1ea0b --- /dev/null +++ b/spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/ArtemisLegacyContainer.java @@ -0,0 +1,33 @@ +/* + * Copyright 2012-present the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.springframework.boot.testsupport.container; + +import org.testcontainers.activemq.ArtemisContainer; +import org.testcontainers.utility.DockerImageName; + +/** + * An {@link ArtemisContainer} for {@code apache/activemq-artemis}. + * + * @author Moritz Halbritter + */ +public final class ArtemisLegacyContainer extends ArtemisContainer { + + public ArtemisLegacyContainer(DockerImageName dockerImageName) { + super(dockerImageName); + } + +} diff --git a/spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/TestImage.java b/spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/TestImage.java index c17c2ea459b..327a3c02715 100644 --- a/spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/TestImage.java +++ b/spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/TestImage.java @@ -25,7 +25,6 @@ import java.util.function.Supplier; import com.redis.testcontainers.RedisContainer; import com.redis.testcontainers.RedisStackContainer; -import org.testcontainers.activemq.ArtemisContainer; import org.testcontainers.cassandra.CassandraContainer; import org.testcontainers.containers.Container; import org.testcontainers.containers.GenericContainer; @@ -80,7 +79,13 @@ public enum TestImage { /** * A container image suitable for testing Artemis. */ - ARTEMIS("apache/activemq-artemis", "2.34.0", () -> ArtemisContainer.class), + ARTEMIS("apache/artemis", "2.53.0", () -> ArtemisContainer.class), + + /** + * A container image suitable for testing Artemis using the legacy + * {@code apache/activemq-artemis} image. + */ + ARTEMIS_LEGACY("apache/activemq-artemis", "2.34.0", () -> ArtemisLegacyContainer.class), /** * A container image suitable for testing Cassandra. diff --git a/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-artemis/src/dockerTest/java/smoketest/artemis/SampleArtemisTests.java b/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-artemis/src/dockerTest/java/smoketest/artemis/SampleArtemisTests.java index e5903c266bb..3b86617b147 100644 --- a/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-artemis/src/dockerTest/java/smoketest/artemis/SampleArtemisTests.java +++ b/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-artemis/src/dockerTest/java/smoketest/artemis/SampleArtemisTests.java @@ -21,7 +21,6 @@ import java.time.Duration; import org.awaitility.Awaitility; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; -import org.testcontainers.activemq.ArtemisContainer; import org.testcontainers.junit.jupiter.Container; import org.testcontainers.junit.jupiter.Testcontainers; @@ -30,6 +29,7 @@ import org.springframework.boot.test.context.SpringBootTest; import org.springframework.boot.test.system.CapturedOutput; import org.springframework.boot.test.system.OutputCaptureExtension; import org.springframework.boot.testcontainers.service.connection.ServiceConnection; +import org.springframework.boot.testsupport.container.ArtemisLegacyContainer; import org.springframework.boot.testsupport.container.TestImage; import static org.assertj.core.api.Assertions.assertThat; @@ -47,7 +47,7 @@ class SampleArtemisTests { @Container @ServiceConnection - private static final ArtemisContainer container = TestImage.container(ArtemisContainer.class); + private static final ArtemisLegacyContainer container = TestImage.container(ArtemisLegacyContainer.class); @Autowired private Producer producer;