From 3d037f9df6d88249160f7449e9d2f1200b741028 Mon Sep 17 00:00:00 2001 From: kdomo Date: Fri, 4 Sep 2026 10:48:58 +0900 Subject: [PATCH] Correct Assert messages that name the wrong parameter Three Assert messages named a parameter that does not exist on the method. In each case the correct name is already used by neighbouring code in the same class. Signed-off-by: kdomo See gh-51568 --- .../main/java/org/springframework/boot/json/JsonWriter.java | 2 +- .../boot/http/client/reactive/ClientHttpConnectorBuilder.java | 4 ++-- .../reactive/HttpComponentsClientHttpConnectorBuilder.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/spring-boot/src/main/java/org/springframework/boot/json/JsonWriter.java b/core/spring-boot/src/main/java/org/springframework/boot/json/JsonWriter.java index 5d85b91d7fa..8ee3ccba5fa 100644 --- a/core/spring-boot/src/main/java/org/springframework/boot/json/JsonWriter.java +++ b/core/spring-boot/src/main/java/org/springframework/boot/json/JsonWriter.java @@ -451,7 +451,7 @@ public interface JsonWriter { */ @SuppressWarnings("unchecked") public Member as(Extractor extractor) { - Assert.notNull(extractor, "'adapter' must not be null"); + Assert.notNull(extractor, "'extractor' must not be null"); Member result = (Member) this; result.valueExtractor = this.valueExtractor.as(extractor::extract); return result; diff --git a/module/spring-boot-http-client/src/main/java/org/springframework/boot/http/client/reactive/ClientHttpConnectorBuilder.java b/module/spring-boot-http-client/src/main/java/org/springframework/boot/http/client/reactive/ClientHttpConnectorBuilder.java index 89cbfcbb27c..d891ff5ce36 100644 --- a/module/spring-boot-http-client/src/main/java/org/springframework/boot/http/client/reactive/ClientHttpConnectorBuilder.java +++ b/module/spring-boot-http-client/src/main/java/org/springframework/boot/http/client/reactive/ClientHttpConnectorBuilder.java @@ -127,7 +127,7 @@ public interface ClientHttpConnectorBuilder { /** * Return a new {@link ClientHttpConnectorBuilder} for the given - * {@code requestFactoryType}. The following implementations are supported: + * {@code clientHttpConnectorType}. The following implementations are supported: *
    *
  • {@link ReactorClientHttpConnector}
  • *
  • {@link JettyClientHttpConnector}
  • @@ -140,7 +140,7 @@ public interface ClientHttpConnectorBuilder { */ @SuppressWarnings("unchecked") static ClientHttpConnectorBuilder of(Class clientHttpConnectorType) { - Assert.notNull(clientHttpConnectorType, "'requestFactoryType' must not be null"); + Assert.notNull(clientHttpConnectorType, "'clientHttpConnectorType' must not be null"); Assert.isTrue(clientHttpConnectorType != ClientHttpConnector.class, "'clientHttpConnectorType' must be an implementation of ClientHttpConnector"); if (clientHttpConnectorType == ReactorClientHttpConnector.class) { diff --git a/module/spring-boot-http-client/src/main/java/org/springframework/boot/http/client/reactive/HttpComponentsClientHttpConnectorBuilder.java b/module/spring-boot-http-client/src/main/java/org/springframework/boot/http/client/reactive/HttpComponentsClientHttpConnectorBuilder.java index d47f8c424ed..6eff3a3c598 100644 --- a/module/spring-boot-http-client/src/main/java/org/springframework/boot/http/client/reactive/HttpComponentsClientHttpConnectorBuilder.java +++ b/module/spring-boot-http-client/src/main/java/org/springframework/boot/http/client/reactive/HttpComponentsClientHttpConnectorBuilder.java @@ -66,7 +66,7 @@ public final class HttpComponentsClientHttpConnectorBuilder */ public HttpComponentsClientHttpConnectorBuilder withHttpClientCustomizer( Consumer httpClientCustomizer) { - Assert.notNull(httpClientCustomizer, "'customizer' must not be null"); + Assert.notNull(httpClientCustomizer, "'httpClientCustomizer' must not be null"); return new HttpComponentsClientHttpConnectorBuilder(getCustomizers(), this.httpClientBuilder.withCustomizer(httpClientCustomizer)); }