diff --git a/module/spring-boot-graphql/src/main/java/org/springframework/boot/graphql/autoconfigure/servlet/GraphQlWebMvcAutoConfiguration.java b/module/spring-boot-graphql/src/main/java/org/springframework/boot/graphql/autoconfigure/servlet/GraphQlWebMvcAutoConfiguration.java index 59f4b8a2b13..43fb107e08a 100644 --- a/module/spring-boot-graphql/src/main/java/org/springframework/boot/graphql/autoconfigure/servlet/GraphQlWebMvcAutoConfiguration.java +++ b/module/spring-boot-graphql/src/main/java/org/springframework/boot/graphql/autoconfigure/servlet/GraphQlWebMvcAutoConfiguration.java @@ -60,7 +60,6 @@ import org.springframework.http.HttpHeaders; import org.springframework.http.HttpMethod; import org.springframework.http.HttpStatus; import org.springframework.http.MediaType; -import org.springframework.http.converter.GenericHttpMessageConverter; import org.springframework.http.converter.HttpMessageConverter; import org.springframework.util.Assert; import org.springframework.web.cors.CorsConfiguration; @@ -190,12 +189,12 @@ public final class GraphQlWebMvcAutoConfiguration { properties.getWebsocket().getConnectionInitTimeout(), properties.getWebsocket().getKeepAlive()); } - private GenericHttpMessageConverter getJsonConverter(HttpMessageConverters converters) { + private HttpMessageConverter getJsonConverter(HttpMessageConverters converters) { return converters.getConverters() .stream() .filter(this::canReadJsonMap) .findFirst() - .map(this::asGenericHttpMessageConverter) + .map(this::asObjectHttpMessageConverter) .orElseThrow(() -> new IllegalStateException("No JSON converter")); } @@ -204,8 +203,8 @@ public final class GraphQlWebMvcAutoConfiguration { } @SuppressWarnings("unchecked") - private GenericHttpMessageConverter asGenericHttpMessageConverter(HttpMessageConverter converter) { - return (GenericHttpMessageConverter) converter; + private HttpMessageConverter asObjectHttpMessageConverter(HttpMessageConverter converter) { + return (HttpMessageConverter) converter; } @Bean diff --git a/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/reactive/GraphQlWebFluxAutoConfigurationTests.java b/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/reactive/GraphQlWebFluxAutoConfigurationTests.java index 7b5bdb0b7fa..489107b7897 100644 --- a/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/reactive/GraphQlWebFluxAutoConfigurationTests.java +++ b/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/reactive/GraphQlWebFluxAutoConfigurationTests.java @@ -22,7 +22,6 @@ import java.util.Map; import java.util.function.Consumer; import graphql.schema.idl.TypeRuntimeWiring; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.springframework.aot.hint.RuntimeHints; @@ -79,7 +78,6 @@ import static org.hamcrest.Matchers.containsString; booksOnSale(minPages: Int) : Book! } """) -@Disabled("Waiting on compatible release") class GraphQlWebFluxAutoConfigurationTests { private static final String BASE_URL = "https://spring.example.org/"; diff --git a/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/security/GraphQlWebFluxSecurityAutoConfigurationTests.java b/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/security/GraphQlWebFluxSecurityAutoConfigurationTests.java index 0798c29af95..c0c5948ede3 100644 --- a/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/security/GraphQlWebFluxSecurityAutoConfigurationTests.java +++ b/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/security/GraphQlWebFluxSecurityAutoConfigurationTests.java @@ -20,7 +20,6 @@ import java.util.Collections; import java.util.function.Consumer; import graphql.schema.idl.TypeRuntimeWiring; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import reactor.core.publisher.Mono; @@ -80,7 +79,6 @@ import static org.springframework.security.config.Customizer.withDefaults; booksOnSale(minPages: Int) : Book! } """) -@Disabled("Waiting on compatible release") class GraphQlWebFluxSecurityAutoConfigurationTests { private static final String BASE_URL = "https://spring.example.org/graphql"; diff --git a/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/security/GraphQlWebMvcSecurityAutoConfigurationTests.java b/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/security/GraphQlWebMvcSecurityAutoConfigurationTests.java index 458c9e16441..13126e4deaf 100644 --- a/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/security/GraphQlWebMvcSecurityAutoConfigurationTests.java +++ b/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/security/GraphQlWebMvcSecurityAutoConfigurationTests.java @@ -18,7 +18,6 @@ package org.springframework.boot.graphql.autoconfigure.security; import graphql.schema.idl.TypeRuntimeWiring; import org.assertj.core.api.ThrowingConsumer; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.springframework.boot.autoconfigure.AutoConfigurations; @@ -80,7 +79,6 @@ import static org.springframework.test.web.servlet.request.MockMvcRequestBuilder booksOnSale(minPages: Int) : Book! } """) -@Disabled("Waiting on compatible release") class GraphQlWebMvcSecurityAutoConfigurationTests { private final WebApplicationContextRunner contextRunner = new WebApplicationContextRunner() diff --git a/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/servlet/GraphQlWebMvcAutoConfigurationTests.java b/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/servlet/GraphQlWebMvcAutoConfigurationTests.java index 04273fb4fef..609d7f5c2c3 100644 --- a/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/servlet/GraphQlWebMvcAutoConfigurationTests.java +++ b/module/spring-boot-graphql/src/test/java/org/springframework/boot/graphql/autoconfigure/servlet/GraphQlWebMvcAutoConfigurationTests.java @@ -21,7 +21,6 @@ import java.util.Map; import graphql.schema.idl.TypeRuntimeWiring; import org.assertj.core.api.ThrowingConsumer; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.springframework.aot.hint.RuntimeHints; @@ -81,7 +80,6 @@ import static org.springframework.test.web.servlet.request.MockMvcRequestBuilder booksOnSale(minPages: Int) : Book! } """) -@Disabled("Waiting on compatible release") class GraphQlWebMvcAutoConfigurationTests { private final WebApplicationContextRunner contextRunner = new WebApplicationContextRunner() diff --git a/smoke-test/spring-boot-smoke-test-graphql/src/test/java/smoketest/graphql/GreetingControllerTests.java b/smoke-test/spring-boot-smoke-test-graphql/src/test/java/smoketest/graphql/GreetingControllerTests.java index 0df79dc6697..452e377268a 100644 --- a/smoke-test/spring-boot-smoke-test-graphql/src/test/java/smoketest/graphql/GreetingControllerTests.java +++ b/smoke-test/spring-boot-smoke-test-graphql/src/test/java/smoketest/graphql/GreetingControllerTests.java @@ -16,7 +16,6 @@ package smoketest.graphql; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.springframework.beans.factory.annotation.Autowired; @@ -29,7 +28,6 @@ import static org.assertj.core.api.Assertions.assertThat; @SpringBootTest @AutoConfigureHttpGraphQlTester -@Disabled("Waiting on compatible release") class GreetingControllerTests { @Autowired