From f76e3b68862d4e77a0ff0d5cfc94bb53251a07b3 Mon Sep 17 00:00:00 2001 From: Alexander Makarov Date: Tue, 25 Aug 2026 12:47:04 +0300 Subject: [PATCH] Remove duplicate adoc generation in DocumentAutoConfigurationClasses The task loaded the auto-configuration metadata twice and wrote every module's adoc file twice. When `load()` and `writeNavAdoc()` were introduced, the pre-existing loop that read each metadata file and called `writeModuleAdoc()` was left in place, so each file was generated once from `load()` and then again, identically, by the loop. Remove the redundant loop. The generated output is unchanged. See gh-51438 Signed-off-by: Alexander Makarov --- .../autoconfigure/DocumentAutoConfigurationClasses.java | 9 --------- 1 file changed, 9 deletions(-) diff --git a/buildSrc/src/main/java/org/springframework/boot/build/autoconfigure/DocumentAutoConfigurationClasses.java b/buildSrc/src/main/java/org/springframework/boot/build/autoconfigure/DocumentAutoConfigurationClasses.java index 8966c50950a..b1bdd9de02d 100644 --- a/buildSrc/src/main/java/org/springframework/boot/build/autoconfigure/DocumentAutoConfigurationClasses.java +++ b/buildSrc/src/main/java/org/springframework/boot/build/autoconfigure/DocumentAutoConfigurationClasses.java @@ -70,15 +70,6 @@ public abstract class DocumentAutoConfigurationClasses extends DefaultTask { FileSystemUtils.deleteRecursively(getOutputDir().getAsFile().get()); List autoConfigurations = load(); autoConfigurations.forEach(this::writeModuleAdoc); - for (File metadataFile : this.autoConfiguration) { - Properties metadata = new Properties(); - try (Reader reader = new FileReader(metadataFile)) { - metadata.load(reader); - } - AutoConfiguration autoConfiguration = new AutoConfiguration(metadata.getProperty("module"), new TreeSet<>( - StringUtils.commaDelimitedListToSet(metadata.getProperty("autoConfigurationClassNames")))); - writeModuleAdoc(autoConfiguration); - } writeNavAdoc(autoConfigurations); }