mirror of
https://github.com/spring-projects/spring-boot.git
synced 2026-09-17 12:09:16 +00:00
Andy Wilkinson
fdbddcf606
Previously, we called getCredentials() to determine whether or not a repository requires authentication. Unfortunately, the method has the unwanted side-effect of assigning empty username and password credentials to a repository that previously did not require authentication and did not, therefore, have any credentials. These empty credentials can then cause subsequent failures because "Username must not be null!". There's no side-effect-free public API for accessing a repository's credentials. Instead, we're using some internal API on AuthenticationSupportedInternal. If this causes problems when upgrading to a new version of Gradle a different approach will be required. For example, we could pass in the repositories in two separate collections: those that require authentication and those that don't. Closes gh-45950