Merge branch '7.0.x'

spring-expression/src/main/java/org/springframework/expression/EvaluationContext.java

@@ -38,6 +38,24 @@ import org.jspecify.annotations.Nullable;
  * manually.</li>
  * </ul>
  *
+ * <p><strong>WARNING</strong>: Evaluating a SpEL expression obtained from an
+ * untrusted source is inherently dangerous, since doing so can effectively
+ * grant that source the ability to execute arbitrary code within the
+ * application. See the class-level documentation for
+ * {@code StandardEvaluationContext} and {@code SimpleEvaluationContext} for
+ * details on the trust model applicable to each implementation. Regardless of
+ * which {@code EvaluationContext} implementation is in use, any restrictions
+ * that an implementation imposes on the SpEL language are provided on a
+ * best-effort basis and do not, by themselves, guarantee that expression
+ * evaluation is safe. An expression can potentially invoke any property, method,
+ * or function reachable via the configured root object, property accessors,
+ * index accessors, resolvers, variables, and functions. It is therefore the
+ * responsibility of the code that configures an {@code EvaluationContext}
+ * &mdash; for example, by supplying a root object or by registering property
+ * accessors, resolvers, variables, or functions &mdash; to ensure that none of
+ * those reachable objects expose operations that would be dangerous if invoked
+ * by an expression from an untrusted source.
+ *
  * @author Andy Clement
  * @author Juergen Hoeller
  * @author Sam Brannen

spring-expression/src/main/java/org/springframework/expression/spel/support/SimpleEvaluationContext.java

@@ -49,8 +49,8 @@ import org.springframework.expression.spel.SpelMessage;
  * should be meaningfully restricted. Examples include but are not limited to
  * data binding expressions, property-based filters, and others. To that effect,
  * {@code SimpleEvaluationContext} is tailored to support only a subset of the
- * SpEL language syntax, for example, excluding references to Java types, constructors,
- * and bean references.
+ * SpEL language syntax — for example, excluding references to Java types,
+ * constructors, and bean references.
  *
  * <p>When creating a {@code SimpleEvaluationContext} you need to choose the level of
  * support that you need for data binding in SpEL expressions:
@@ -65,9 +65,10 @@ import org.springframework.expression.spel.SpelMessage;
  * read-only access to properties via {@link DataBindingPropertyAccessor}. Similarly,
  * {@link SimpleEvaluationContext#forReadWriteDataBinding()} enables read and write access
  * to properties. Alternatively, configure custom accessors via
- * {@link SimpleEvaluationContext#forPropertyAccessors}, potentially
- * {@linkplain Builder#withAssignmentDisabled() disable assignment}, and optionally
- * activate method resolution and/or a type converter through the builder.
+ * {@link SimpleEvaluationContext#forPropertyAccessors}, consider
+ * {@linkplain Builder#withAssignmentDisabled() disabling assignment} (recommended),
+ * and optionally activate method resolution and/or a type converter through the
+ * builder.
  *
  * <p>Note that {@code SimpleEvaluationContext} is typically not configured
  * with a default root object. Instead it is meant to be created once and
@@ -87,6 +88,23 @@ import org.springframework.expression.spel.SpelMessage;
  * <p>For more power and flexibility, in particular for internal configuration
  * scenarios, consider using {@link StandardEvaluationContext} instead.
  *
+ * <p><strong>WARNING</strong>: {@code SimpleEvaluationContext} takes a
+ * best-effort approach to restricting the SpEL language to a subset of its
+ * features; however, it cannot guarantee that evaluation of an expression is
+ * safe. Evaluating a SpEL expression obtained from an untrusted source is inherently
+ * dangerous and should generally be avoided, since doing so can effectively grant
+ * that source the ability to execute arbitrary code within the application. Even
+ * within the restricted language subset supported by {@code SimpleEvaluationContext},
+ * an expression can potentially invoke any property, method, or function reachable
+ * via the configured root object, property accessors, method resolvers, variables,
+ * and functions. It is therefore the responsibility of the code that configures a
+ * {@code SimpleEvaluationContext} &mdash; for example, by supplying a root
+ * object or by registering property accessors, method resolvers, variables, or
+ * functions &mdash; to ensure that none of those reachable objects expose
+ * operations that would be dangerous if invoked by an expression from an
+ * untrusted source. For details on what qualifies as a "trusted" source, see
+ * {@link StandardEvaluationContext}.
+ *
  * @author Rossen Stoyanchev
  * @author Juergen Hoeller
  * @author Sam Brannen

spring-expression/src/main/java/org/springframework/expression/spel/support/StandardEvaluationContext.java

@@ -64,6 +64,22 @@ import org.springframework.util.Assert;
  * consider using {@link SimpleEvaluationContext} instead which allows for
  * opting into several SpEL features as needed by specific use cases.
  *
+ * <p><strong>WARNING</strong>: {@code StandardEvaluationContext} exposes the
+ * complete SpEL language, including the ability to invoke arbitrary constructors
+ * and methods and to read and write arbitrary properties and fields &mdash; all
+ * backed by reflection &mdash; as well as the ability to reference beans in an
+ * {@code ApplicationContext} via a configured {@link BeanResolver}. For that
+ * reason, a {@code StandardEvaluationContext} must <strong>never</strong> be used
+ * to evaluate a SpEL expression obtained from an untrusted source. In this context,
+ * a "trusted" source is limited to a developer of the application or an
+ * administrator who is responsible for configuring or operating the
+ * application. Any other source of a SpEL expression &mdash; for example, an
+ * expression supplied by an end user or received from an external system
+ * &mdash; must be treated as untrusted. Note, however, that evaluating a SpEL
+ * expression obtained from an untrusted source is inherently dangerous
+ * regardless of the {@code EvaluationContext} implementation in use; see
+ * {@link SimpleEvaluationContext} for further details.
+ *
  * @author Andy Clement
  * @author Juergen Hoeller
  * @author Sam Brannen