From 3178df92bdd36b4e1c4147655aadb1dc898c5ae8 Mon Sep 17 00:00:00 2001 From: Sam Brannen <104798+sbrannen@users.noreply.github.com> Date: Mon, 14 Sep 2026 18:15:02 +0200 Subject: [PATCH] Consistently use `while (true)` instead of `for (;;)` across the codebase --- .../core/io/buffer/SubscriberInputStream.java | 6 +++--- .../java/org/springframework/util/ConcurrentLruCache.java | 2 +- .../simp/broker/OrderedMessageChannelDecorator.java | 2 +- .../springframework/http/client/SubscriberInputStream.java | 6 +++--- .../server/reactive/AbstractListenerWriteProcessor.java | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/spring-core/src/main/java/org/springframework/core/io/buffer/SubscriberInputStream.java b/spring-core/src/main/java/org/springframework/core/io/buffer/SubscriberInputStream.java index 65ac925b394..8fe753019ad 100644 --- a/spring-core/src/main/java/org/springframework/core/io/buffer/SubscriberInputStream.java +++ b/spring-core/src/main/java/org/springframework/core/io/buffer/SubscriberInputStream.java @@ -169,7 +169,7 @@ final class SubscriberInputStream extends InputStream implements Subscriber { * current size of the cache, unless the node has already been removed. */ private void markAsRemoved(Node node) { - for (; ; ) { + while (true) { CacheEntry current = node.get(); if (current.state == CacheEntryState.REMOVED) { return; diff --git a/spring-messaging/src/main/java/org/springframework/messaging/simp/broker/OrderedMessageChannelDecorator.java b/spring-messaging/src/main/java/org/springframework/messaging/simp/broker/OrderedMessageChannelDecorator.java index e2b4bb17fd4..70b7378fea9 100644 --- a/spring-messaging/src/main/java/org/springframework/messaging/simp/broker/OrderedMessageChannelDecorator.java +++ b/spring-messaging/src/main/java/org/springframework/messaging/simp/broker/OrderedMessageChannelDecorator.java @@ -89,7 +89,7 @@ public class OrderedMessageChannelDecorator implements MessageChannel { } private void sendNextMessage() { - for (;;) { + while (true) { Message message = this.messages.peek(); if (message != null) { try { diff --git a/spring-web/src/main/java/org/springframework/http/client/SubscriberInputStream.java b/spring-web/src/main/java/org/springframework/http/client/SubscriberInputStream.java index 9967b2a1d95..b1e0490afe0 100644 --- a/spring-web/src/main/java/org/springframework/http/client/SubscriberInputStream.java +++ b/spring-web/src/main/java/org/springframework/http/client/SubscriberInputStream.java @@ -190,7 +190,7 @@ final class SubscriberInputStream extends InputStream implements Flow.Subscri } int addWork() { - for (;;) { + while (true) { int produced = this.workAmount.getPlain(); if (produced == Integer.MIN_VALUE) { @@ -319,7 +319,7 @@ final class SubscriberInputStream extends InputStream implements Flow.Subscri this.available = null; int actualWorkAmount = this.workAmount.getAcquire(); - for (;;) { + while (true) { if (this.closed) { return CLOSED; } @@ -354,7 +354,7 @@ final class SubscriberInputStream extends InputStream implements Flow.Subscri void cleanAndFinalize() { this.available = null; - for (;;) { + while (true) { int workAmount = this.workAmount.getPlain(); T value; while ((value = this.queue.poll()) != null) { diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerWriteProcessor.java b/spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerWriteProcessor.java index d79d7328182..e6a3bc14437 100644 --- a/spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerWriteProcessor.java +++ b/spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerWriteProcessor.java @@ -180,7 +180,7 @@ public abstract class AbstractListenerWriteProcessor implements Processor