From 77c24b28b6b400c6ecad6b30b70850939a98a355 Mon Sep 17 00:00:00 2001 From: rstoyanchev Date: Mon, 26 Jan 2026 10:51:00 +0000 Subject: [PATCH] Polishing in ReactorClientHttpConnector --- .../http/client/reactive/ReactorClientHttpConnector.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/spring-web/src/main/java/org/springframework/http/client/reactive/ReactorClientHttpConnector.java b/spring-web/src/main/java/org/springframework/http/client/reactive/ReactorClientHttpConnector.java index ee81b325e7b..3b0a14b3cb9 100644 --- a/spring-web/src/main/java/org/springframework/http/client/reactive/ReactorClientHttpConnector.java +++ b/spring-web/src/main/java/org/springframework/http/client/reactive/ReactorClientHttpConnector.java @@ -168,7 +168,7 @@ public class ReactorClientHttpConnector implements ClientHttpConnector, SmartLif .responseConnection((response, connection) -> { ReactorClientHttpResponse clientResponse = new ReactorClientHttpResponse(response, connection); responseRef.set(clientResponse); - clearChannelAttribute(connection); + registerAttributeCallback(connection); return Mono.just((ClientHttpResponse) clientResponse); }) .next() @@ -198,12 +198,13 @@ public class ReactorClientHttpConnector implements ClientHttpConnector, SmartLif return new ReactorClientHttpRequest(method, uri, request, nettyOutbound); } - private static void clearChannelAttribute(Connection connection) { - connection.onTerminate().subscribe( - aVoid -> {}, ex -> clearAttribute(connection), () -> clearAttribute(connection)); + private static void registerAttributeCallback(Connection connection) { + connection.onTerminate().subscribe(aVoid -> {}, + ex -> clearAttribute(connection), () -> clearAttribute(connection)); } private static void clearAttribute(Connection connection) { + // Deprecation note on remove method: consider using set(Object) (with value of null) connection.channel().attr(ATTRIBUTES_KEY).set(null); }