spring/spring-framework
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-framework.git synced 2026-10-03 21:49:03 +00:00
Code Issues Projects Releases Wiki Activity

Convert assertThat(x.equals(y)).isTrue() to assertThat(x).isEqualTo(y)

Browse Source 
Search:

  assertThat\((?!\s*Arrays\.)((?:[^()]+|\([^()]*\))+)\.equals\(\s*((?:[^()]+|\([^()]*\))+)\s*\)\)(.*)\.isTrue\(\)

Replace:

  assertThat($1)$3.isEqualTo($2)

See gh-36504
This commit is contained in:
Sam Brannen
2026-03-20 10:54:42 +01:00
parent 2ce21f7654
commit 87c4acd7ac
28 changed files with 149 additions and 167 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spring-context/src/test/java/org/springframework/beans/factory/xml/XmlBeanFactoryTests.java
+2 -2
View File
@@ -152,8 +152,8 @@ class XmlBeanFactoryTests {
assertThat(emmasJenks.getName()).as("Emmas jenks has right name").isEqualTo("Andrew");
assertThat(emmasJenks).as("Emmas doesn't equal new ref").isNotSameAs(xbf.getBean("jenks"));
assertThat(georgiasJenks.getName()).as("Georgias jenks has right name").isEqualTo("Andrew");
assertThat(emmasJenks.equals(georgiasJenks)).as("They are object equal").isTrue();
assertThat(emmasJenks.equals(xbf.getBean("jenks"))).as("They object equal direct ref").isTrue();
assertThat(emmasJenks).as("They are object equal").isEqualTo(georgiasJenks);
assertThat(emmasJenks).as("They object equal direct ref").isEqualTo(xbf.getBean("jenks"));
}
@Test
spring-context/src/test/java/org/springframework/validation/DataBinderFieldAccessTests.java
+1 -1
View File
@@ -58,7 +58,7 @@ class DataBinderFieldAccessTests {
Map<?, ?> m = binder.getBindingResult().getModel();
assertThat(m).as("There is one element in map").hasSize(2);
FieldAccessBean tb = (FieldAccessBean) m.get("person");
assertThat(tb.equals(rod)).as("Same object").isTrue();
assertThat(tb).as("Same object").isEqualTo(rod);
}
@Test
spring-context/src/test/java/org/springframework/validation/DataBinderTests.java
+2 -2
View File
@@ -113,7 +113,7 @@ class DataBinderTests {
Map<?, ?> map = binder.getBindingResult().getModel();
assertThat(map).as("There is one element in map").hasSize(2);
TestBean tb = (TestBean) map.get("person");
assertThat(tb.equals(rod)).as("Same object").isTrue();
assertThat(tb).as("Same object").isEqualTo(rod);
BindingResult other = new DataBinder(rod, "person").getBindingResult();
assertThat(binder.getBindingResult()).isEqualTo(other);
@@ -793,7 +793,7 @@ class DataBinderTests {
Map<?,?> m = binder.getBindingResult().getModel();
assertThat(m).as("There is one element in map").hasSize(2);
TestBean tb = (TestBean) m.get("person");
assertThat(tb.equals(rod)).as("Same object").isTrue();
assertThat(tb).as("Same object").isEqualTo(rod);
}
@Test