Avoid the use of assertThat(Arrays.equals(...))

See gh-36504
This commit is contained in:
Sam Brannen
2026-03-20 10:54:57 +01:00
parent 29ea530525
commit 8ca0262e2f
10 changed files with 22 additions and 30 deletions
@@ -104,7 +104,7 @@ abstract class AbstractHttpRequestFactoryTests extends AbstractMockWebServerTest
.as("Header value not found")
.isTrue();
byte[] result = FileCopyUtils.copyToByteArray(response.getBody());
assertThat(Arrays.equals(body, result)).as("Invalid body").isTrue();
assertThat(result).as("Invalid body").isEqualTo(body);
}
}
@@ -19,7 +19,6 @@ package org.springframework.http.client;
import java.io.IOException;
import java.net.URI;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
@@ -192,7 +191,7 @@ class InterceptingClientHttpRequestFactoryTests {
ClientHttpRequest request = requestFactory.createRequest(URI.create("https://example.com"), HttpMethod.GET);
request.execute();
assertThat(Arrays.equals(changedBody, requestMock.getBodyAsBytes())).isTrue();
assertThat(requestMock.getBodyAsBytes()).isEqualTo(changedBody);
assertThat(requestMock.getHeaders().getContentLength()).isEqualTo(changedBody.length);
}
@@ -19,7 +19,6 @@ package org.springframework.http.converter;
import java.io.FileNotFoundException;
import java.io.IOException;
import java.io.InputStream;
import java.util.Arrays;
import org.junit.jupiter.api.Test;
@@ -144,7 +143,7 @@ class ResourceHttpMessageConverterTests {
Resource body = new ByteArrayResource(byteArray);
converter.write(body, null, outputMessage);
assertThat(Arrays.equals(byteArray, outputMessage.getBodyAsBytes())).isTrue();
assertThat(outputMessage.getBodyAsBytes()).isEqualTo(byteArray);
}
@Test // SPR-12999