From 951c1f306a20149c5dc3cc65b5169a08aced51ca Mon Sep 17 00:00:00 2001 From: Sam Brannen <104798+sbrannen@users.noreply.github.com> Date: Thu, 13 Aug 2026 17:14:30 +0200 Subject: [PATCH] Revert "Polish MockCookieTests" This reverts commit 27a85be4e074d763e157d3393c72f34fa372df44 due to code freeze on main. See gh-37134 --- .../springframework/mock/web/MockCookieTests.java | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/spring-test/src/test/java/org/springframework/mock/web/MockCookieTests.java b/spring-test/src/test/java/org/springframework/mock/web/MockCookieTests.java index 1f032efb64d..749f12192e6 100644 --- a/spring-test/src/test/java/org/springframework/mock/web/MockCookieTests.java +++ b/spring-test/src/test/java/org/springframework/mock/web/MockCookieTests.java @@ -22,7 +22,6 @@ import java.time.format.DateTimeParseException; import org.junit.jupiter.api.Test; import org.junit.jupiter.params.ParameterizedTest; -import org.junit.jupiter.params.provider.NullAndEmptySource; import org.junit.jupiter.params.provider.ValueSource; import static org.assertj.core.api.Assertions.assertThat; @@ -115,10 +114,16 @@ class MockCookieTests { assertThat(cookie.getValue()).isEqualTo(value); } + @Test + void parseNullHeader() { + assertThatIllegalArgumentException() + .isThrownBy(() -> MockCookie.parse(null)) + .withMessageContaining("Set-Cookie header must not be null or empty"); + } + @ParameterizedTest - @NullAndEmptySource - @ValueSource(strings = " ") - void parseNullOrEmptyHeader(String header) { + @ValueSource(strings = {"", " "}) + void parseEmptyHeader(String header) { assertThatIllegalArgumentException() .isThrownBy(() -> MockCookie.parse(header)) .withMessageContaining("Set-Cookie header must not be null or empty");