spring/spring-framework
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-framework.git synced 2026-09-22 05:49:04 +00:00
Code Issues Projects Releases Wiki Activity

Close contexts when clearing test context cache

Browse Source 
This updates the TestContext Framework cache so that clearing the
cache also closes cached ConfigurableApplicationContext instances
instead of only dropping the internal references. The implementation
reuses the existing removal path, preserving the hierarchy-aware close
behavior already used by cache eviction/removal.

The ContextCache contract now documents the close behavior for
clear(), and LruContextCacheTests covers both clear() and reset(),
since reset() delegates to clear().

See gh-26196
Closes gh-36825

Signed-off-by: Will-thom <116388885+Will-thom@users.noreply.github.com>
This commit is contained in:
Will-thom
2026-08-31 13:07:54 +02:00
committed by Sam Brannen
parent 5524fc6a55
commit 97067f9c9c
3 changed files with 43 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spring-test/src/test/java/org/springframework/test/context/cache/LruContextCacheTests.java
Vendored
+36
View File
@@ -81,6 +81,42 @@ class LruContextCacheTests {
assertThatIllegalArgumentException().isThrownBy(() -> new DefaultContextCache(0));
}
@Test
void clearClosesContexts() {
DefaultContextCache cache = new DefaultContextCache(4);
cache.put(fooConfig, key -> fooContext);
cache.put(barConfig, key -> barContext);
cache.put(bazConfig, key -> bazContext);
assertCacheContents(cache, "Foo", "Bar", "Baz");
cache.clear();
assertCacheContents(cache);
verify(fooContext, times(1)).close();
verify(barContext, times(1)).close();
verify(bazContext, times(1)).close();
verify(abcContext, never()).close();
}
@Test
void resetClosesContexts() {
DefaultContextCache cache = new DefaultContextCache(4);
cache.put(fooConfig, key -> fooContext);
cache.put(barConfig, key -> barContext);
cache.get(fooConfig);
assertThat(cache.getHitCount()).isEqualTo(1);
assertCacheContents(cache, "Bar", "Foo");
cache.reset();
assertCacheContents(cache);
assertThat(cache.getHitCount()).isZero();
verify(fooContext, times(1)).close();
verify(barContext, times(1)).close();
}
@Nested
@SuppressWarnings("deprecation")