From b2277014735d4b7879689a702eaaaf8962d1b006 Mon Sep 17 00:00:00 2001
From: rstoyanchev <rossen.stoyanchev@broadcom.com>
Date: Tue, 10 Feb 2026 10:12:15 +0000
Subject: [PATCH] Optimize RequestMappingInfo hashcode calculation

Precalculated hashcode makes sense for infos in the registry, but
matched infos created on the fly don't need it.

Closes gh-36279
---
 .../mvc/method/RequestMappingInfo.java        | 47 ++++++++++++-------
 1 file changed, 30 insertions(+), 17 deletions(-)

diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/RequestMappingInfo.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/RequestMappingInfo.java
index 3a400624b4f..bef16b4fc7d 100644
--- a/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/RequestMappingInfo.java
+++ b/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/RequestMappingInfo.java
@@ -104,7 +104,7 @@ public final class RequestMappingInfo implements RequestCondition<RequestMapping
 
 	private final RequestConditionHolder customConditionHolder;
 
-	private final int hashCode;
+	private @Nullable Integer hashCode;
 
 	private final BuilderConfiguration options;
 
@@ -169,6 +169,22 @@ public final class RequestMappingInfo implements RequestCondition<RequestMapping
 			ProducesRequestCondition producesCondition, VersionRequestCondition versionCondition,
 			RequestConditionHolder customCondition, BuilderConfiguration options) {
 
+		this(name, pathPatternsCondition, patternsCondition,
+				methodsCondition, paramsCondition, headersCondition,
+				consumesCondition, producesCondition, versionCondition,
+				customCondition, options, true);
+	}
+
+	@SuppressWarnings("removal")
+	private RequestMappingInfo(@Nullable String name,
+			@Nullable PathPatternsRequestCondition pathPatternsCondition,
+			@Nullable PatternsRequestCondition patternsCondition,
+			RequestMethodsRequestCondition methodsCondition, ParamsRequestCondition paramsCondition,
+			HeadersRequestCondition headersCondition, ConsumesRequestCondition consumesCondition,
+			ProducesRequestCondition producesCondition, VersionRequestCondition versionCondition,
+			RequestConditionHolder customCondition, BuilderConfiguration options,
+			boolean calculateHashCode) {
+
 		Assert.isTrue(pathPatternsCondition != null || patternsCondition != null,
 				"Neither PathPatterns nor String patterns condition");
 
@@ -184,11 +200,9 @@ public final class RequestMappingInfo implements RequestCondition<RequestMapping
 		this.customConditionHolder = customCondition;
 		this.options = options;
 
-		this.hashCode = calculateHashCode(
-				this.pathPatternsCondition, this.patternsCondition,
-				this.methodsCondition, this.paramsCondition, this.headersCondition,
-				this.consumesCondition, this.producesCondition, this.versionCondition,
-				this.customConditionHolder);
+		if (calculateHashCode) {
+			this.hashCode = calculateHashCode();
+		}
 	}
 
 
@@ -448,7 +462,7 @@ public final class RequestMappingInfo implements RequestCondition<RequestMapping
 			return null;
 		}
 		return new RequestMappingInfo(this.name, pathPatterns, patterns,
-				methods, params, headers, consumes, produces, version, custom, this.options);
+				methods, params, headers, consumes, produces, version, custom, this.options, false);
 	}
 
 	/**
@@ -519,20 +533,19 @@ public final class RequestMappingInfo implements RequestCondition<RequestMapping
 
 	@Override
 	public int hashCode() {
+		if (this.hashCode == null) {
+			this.hashCode = calculateHashCode();
+		}
 		return this.hashCode;
 	}
 
 	@SuppressWarnings({"ConstantConditions", "NullAway", "removal"})
-	private static int calculateHashCode(
-			@Nullable PathPatternsRequestCondition pathPatterns, @Nullable PatternsRequestCondition patterns,
-			RequestMethodsRequestCondition methods, ParamsRequestCondition params, HeadersRequestCondition headers,
-			ConsumesRequestCondition consumes, ProducesRequestCondition produces,
-			VersionRequestCondition version, RequestConditionHolder custom) {
-
-		return (pathPatterns != null ? pathPatterns : patterns).hashCode() * 31 +
-				methods.hashCode() + params.hashCode() +
-				headers.hashCode() + consumes.hashCode() + produces.hashCode() +
-				version.hashCode() + custom.hashCode();
+	private int calculateHashCode() {
+		return (this.pathPatternsCondition != null ? this.pathPatternsCondition : this.patternsCondition).hashCode() * 31 +
+				this.methodsCondition.hashCode() +
+				this.paramsCondition.hashCode() + this.headersCondition.hashCode() +
+				this.consumesCondition.hashCode() + this.producesCondition.hashCode() +
+				this.versionCondition.hashCode() + this.customConditionHolder.hashCode();
 	}
 
 	@Override