spring/spring-framework
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-framework.git synced 2026-09-21 21:39:05 +00:00
Code Issues Projects Releases Wiki Activity

Minor optimization in Tomcat header adapters

Browse Source 
get method skips containsKey and instead checks if the enumeration
has elements, which should give the same behavior other than for
headers without values.

See gh-36334
This commit is contained in:
rstoyanchev
2026-02-16 17:38:01 +00:00
parent 5baa4fdd69
commit d712ec3d49
2 changed files with 41 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spring-web/src/test/java/org/springframework/http/server/reactive/HeadersAdaptersTests.java
+8 -6
View File
@@ -298,12 +298,14 @@ class HeadersAdaptersTests {
static Stream<Arguments> nativeHeadersWithCasedEntries() {
return Stream.of(
argumentSet("Netty", new Netty4HeadersAdapter(withHeaders(new DefaultHttpHeaders(), h -> h::add))),
argumentSet("Tomcat", new TomcatHeadersAdapter(withHeaders(new MimeHeaders(),
h -> (k, v) -> h.addValue(k).setString(v)))),
argumentSet("Jetty", new JettyHeadersAdapter(withHeaders(HttpFields.build(), h -> h::add))),
argumentSet("HttpComponents", new HttpComponentsHeadersAdapter(withHeaders(new HttpGet("https://example.com"),
h -> h::addHeader)))
argumentSet("Netty", new Netty4HeadersAdapter(
withHeaders(new DefaultHttpHeaders(), h -> h::add))),
argumentSet("Tomcat", new TomcatHeadersAdapter(
withHeaders(new MimeHeaders(), h -> (k, v) -> h.addValue(k).setString(v)))),
argumentSet("Jetty", new JettyHeadersAdapter(
withHeaders(HttpFields.build(), h -> h::add))),
argumentSet("HttpComponents", new HttpComponentsHeadersAdapter(
withHeaders(new HttpGet("https://example.com"), h -> h::addHeader)))
);
}