spring/spring-framework
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-framework.git synced 2026-10-05 22:49:02 +00:00
Code Issues Projects Releases Wiki Activity

Improve Javadoc and tests for BackOff strategies

Browse Source
This commit is contained in:
Sam Brannen
2025-06-27 16:04:32 +02:00
parent 28f9adf88e
commit d97288a74e
5 changed files with 43 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spring-core/src/test/java/org/springframework/util/ExponentialBackOffTests.java
+8 -7
View File
@@ -92,28 +92,29 @@ class ExponentialBackOffTests {
}
@Test
void startReturnDifferentInstances() {
void startReturnsDifferentInstances() {
ExponentialBackOff backOff = new ExponentialBackOff();
backOff.setInitialInterval(2000L);
backOff.setMultiplier(2.0);
backOff.setMaxElapsedTime(4000L);
BackOffExecution execution = backOff.start();
BackOffExecution execution1 = backOff.start();
BackOffExecution execution2 = backOff.start();
assertThat(execution.nextBackOff()).isEqualTo(2000L);
assertThat(execution1).isNotSameAs(execution2);
assertThat(execution1.nextBackOff()).isEqualTo(2000L);
assertThat(execution2.nextBackOff()).isEqualTo(2000L);
assertThat(execution.nextBackOff()).isEqualTo(4000L);
assertThat(execution1.nextBackOff()).isEqualTo(4000L);
assertThat(execution2.nextBackOff()).isEqualTo(4000L);
assertThat(execution.nextBackOff()).isEqualTo(BackOffExecution.STOP);
assertThat(execution1.nextBackOff()).isEqualTo(BackOffExecution.STOP);
assertThat(execution2.nextBackOff()).isEqualTo(BackOffExecution.STOP);
}
@Test
void invalidInterval() {
ExponentialBackOff backOff = new ExponentialBackOff();
assertThatIllegalArgumentException().isThrownBy(() ->
backOff.setMultiplier(0.9));
assertThatIllegalArgumentException().isThrownBy(() -> backOff.setMultiplier(0.9));
}
@Test
spring-core/src/test/java/org/springframework/util/FixedBackOffTests.java
+9 -4
View File
@@ -24,6 +24,8 @@ import org.springframework.util.backoff.FixedBackOff;
import static org.assertj.core.api.Assertions.assertThat;
/**
* Tests for {@link FixedBackOff}.
*
* @author Stephane Nicoll
*/
class FixedBackOffTests {
@@ -54,14 +56,17 @@ class FixedBackOffTests {
}
@Test
void startReturnDifferentInstances() {
void startReturnsDifferentInstances() {
FixedBackOff backOff = new FixedBackOff(100L, 1);
BackOffExecution execution = backOff.start();
BackOffExecution execution1 = backOff.start();
BackOffExecution execution2 = backOff.start();
assertThat(execution.nextBackOff()).isEqualTo(100L);
assertThat(execution1).isNotSameAs(execution2);
assertThat(execution1.nextBackOff()).isEqualTo(100L);
assertThat(execution2.nextBackOff()).isEqualTo(100L);
assertThat(execution.nextBackOff()).isEqualTo(BackOffExecution.STOP);
assertThat(execution1.nextBackOff()).isEqualTo(BackOffExecution.STOP);
assertThat(execution2.nextBackOff()).isEqualTo(BackOffExecution.STOP);
}