spring/spring-framework
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-framework.git synced 2026-09-21 21:39:05 +00:00
Code Issues Projects Releases Wiki Activity

validate samesite attribute in ResponseCookie

Browse Source 
Signed-off-by: dxbjavid <dxbjavid@gmail.com>
This commit is contained in:
dxbjavid
2026-09-04 18:27:48 +02:00
committed by Brian Clozel
parent 19fdc0b77c
commit e92bf76055
2 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spring-web/src/test/java/org/springframework/http/ResponseCookieTests.java
+11
View File
@@ -82,6 +82,17 @@ class ResponseCookieTests {
.hasMessageContaining("invalid cookie domain char"));
}
@Test
void sameSiteChecks() {
Arrays.asList("Strict", "Lax", "None")
.forEach(sameSite -> ResponseCookie.from("n", "v").sameSite(sameSite).build());
Arrays.asList("Lax\r\nSet-Cookie: x=y", "Lax\n", "La;x", "Lax\t", "Lax\u0005")
.forEach(sameSite -> assertThatThrownBy(() -> ResponseCookie.from("n", "v").sameSite(sameSite).build())
.hasMessageContaining("Invalid cookie SameSite char"));
}
@Test // gh-24663
void domainWithEmptyDoubleQuotes() {