= code cleanup : modified inner class to 'static' if possible

This commit is contained in:
zavakid
2020-09-18 00:49:48 +08:00
parent 5065fea963
commit e7de8289cd
6 changed files with 8 additions and 8 deletions
@@ -387,7 +387,7 @@ public class MysqlMultiStageCoprocessor extends AbstractCanalLifeCycle implement
} }
} }
class MessageEvent { static class MessageEvent {
private LogBuffer buffer; private LogBuffer buffer;
private CanalEntry.Entry entry; private CanalEntry.Entry entry;
@@ -437,7 +437,7 @@ public class MysqlMultiStageCoprocessor extends AbstractCanalLifeCycle implement
} }
class SimpleFatalExceptionHandler implements ExceptionHandler { static class SimpleFatalExceptionHandler implements ExceptionHandler {
@Override @Override
public void handleEventException(final Throwable ex, final long sequence, final Object event) { public void handleEventException(final Throwable ex, final long sequence, final Object event) {
@@ -125,7 +125,7 @@ public class EntryCollector extends Collector implements InstanceRegistry {
} }
} }
private class EntryMetricsHolder { private static class EntryMetricsHolder {
private AtomicLong latestExecTime; private AtomicLong latestExecTime;
private AtomicLong transactionCounter; private AtomicLong transactionCounter;
private List<String> destLabelValues; private List<String> destLabelValues;
@@ -81,7 +81,7 @@ public class MetaCollector extends Collector implements InstanceRegistry {
instances.remove(destination); instances.remove(destination);
} }
private class MetaMetricsHolder { private static class MetaMetricsHolder {
private List<String> infoLabelValues; private List<String> infoLabelValues;
private List<String> destLabelValues; private List<String> destLabelValues;
private CanalMetaManager metaManager; private CanalMetaManager metaManager;
@@ -141,7 +141,7 @@ public class ParserCollector extends Collector implements InstanceRegistry {
instances.remove(destination); instances.remove(destination);
} }
private class ParserMetricsHolder { private static class ParserMetricsHolder {
private List<String> parserLabelValues; private List<String> parserLabelValues;
private List<String> modeLabelValues; private List<String> modeLabelValues;
// metrics for single parser // metrics for single parser
@@ -151,7 +151,7 @@ public class ParserCollector extends Collector implements InstanceRegistry {
private boolean isParallel; private boolean isParallel;
} }
private class GroupParserMetricsHolder extends ParserMetricsHolder { private static class GroupParserMetricsHolder extends ParserMetricsHolder {
private final List<ParserMetricsHolder> holders = new ArrayList<>(); private final List<ParserMetricsHolder> holders = new ArrayList<>();
} }
@@ -80,7 +80,7 @@ public class SinkCollector extends Collector implements InstanceRegistry {
instances.remove(destination); instances.remove(destination);
} }
private class SinkMetricsHolder { private static class SinkMetricsHolder {
private AtomicLong eventsSinkBlockingTime; private AtomicLong eventsSinkBlockingTime;
private List<String> destLabelValues; private List<String> destLabelValues;
@@ -174,7 +174,7 @@ public class StoreCollector extends Collector implements InstanceRegistry {
instances.remove(destination); instances.remove(destination);
} }
private class StoreMetricsHolder { private static class StoreMetricsHolder {
private AtomicLong putSeq; private AtomicLong putSeq;
private AtomicLong ackSeq; private AtomicLong ackSeq;
private BatchMode batchMode; private BatchMode batchMode;