spring/spring-boot
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-boot.git synced 2026-09-17 12:09:16 +00:00
Code Issues Projects Releases Wiki Activity

Add nullability annotations to tests in module/spring-boot-session

Browse Source 
See gh-47263
This commit is contained in:
Moritz Halbritter
2025-10-15 16:58:19 +02:00
parent 26d6880998
commit 07e9edee7d
3 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
module/spring-boot-session/build.gradle
+4
View File
@@ -56,3 +56,7 @@ dependencies {
testRuntimeOnly("ch.qos.logback:logback-classic")
}
tasks.named("compileTestJava") {
options.nullability.checking = "tests"
}
module/spring-boot-session/src/test/java/org/springframework/boot/session/actuate/endpoint/SessionsEndpointTests.java
+4 -1
View File
@@ -55,7 +55,9 @@ class SessionsEndpointTests {
void sessionsForUsername() {
given(this.indexedSessionRepository.findByPrincipalName("user"))
.willReturn(Collections.singletonMap(session.getId(), session));
List<SessionDescriptor> result = this.endpoint.sessionsForUsername("user").getSessions();
SessionsDescriptor sessions = this.endpoint.sessionsForUsername("user");
assertThat(sessions).isNotNull();
List<SessionDescriptor> result = sessions.getSessions();
assertThat(result).hasSize(1);
assertThat(result.get(0).getId()).isEqualTo(session.getId());
assertThat(result.get(0).getAttributeNames()).isEqualTo(session.getAttributeNames());
@@ -76,6 +78,7 @@ class SessionsEndpointTests {
void getSession() {
given(this.sessionRepository.findById(session.getId())).willReturn(session);
SessionDescriptor result = this.endpoint.getSession(session.getId());
assertThat(result).isNotNull();
assertThat(result.getId()).isEqualTo(session.getId());
assertThat(result.getAttributeNames()).isEqualTo(session.getAttributeNames());
assertThat(result.getCreationTime()).isEqualTo(session.getCreationTime());
module/spring-boot-session/src/test/java/org/springframework/boot/session/autoconfigure/SessionAutoConfigurationTests.java
+6 -1
View File
@@ -19,6 +19,9 @@ package org.springframework.boot.session.autoconfigure;
import java.util.Collections;
import jakarta.servlet.DispatcherType;
import jakarta.servlet.FilterChain;
import jakarta.servlet.ServletRequest;
import jakarta.servlet.ServletResponse;
import org.assertj.core.api.InstanceOfAssertFactories;
import org.junit.jupiter.api.Test;
import org.mockito.InOrder;
@@ -64,9 +67,11 @@ class SessionAutoConfigurationTests {
this.contextRunner.withUserConfiguration(SessionRepositoryConfiguration.class).run((context) -> {
AbstractFilterRegistrationBean<?> registration = context.getBean(AbstractFilterRegistrationBean.class);
DelegatingFilterProxy delegatingFilterProxy = (DelegatingFilterProxy) registration.getFilter();
assertThat(delegatingFilterProxy).isNotNull();
try {
// Trigger actual initialization
delegatingFilterProxy.doFilter(null, null, null);
delegatingFilterProxy.doFilter(mock(ServletRequest.class), mock(ServletResponse.class),
mock(FilterChain.class));
}
catch (Exception ex) {
// Ignore