spring/spring-boot
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-boot.git synced 2026-10-10 03:19:01 +00:00
Code Issues Projects Releases Wiki Activity

Use isNoop() instead of Observation.NOOP

Browse Source 
See gh-47072
This commit is contained in:
Jonatan Ivanov
2025-09-09 08:58:17 +02:00
committed by Stéphane Nicoll
parent 6207e41473
commit 9e9e412335
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
module/spring-boot-micrometer-observation/src/test/java/org/springframework/boot/micrometer/observation/autoconfigure/ObservationAutoConfigurationTests.java
+4 -4
View File
@@ -99,11 +99,11 @@ class ObservationAutoConfigurationTests {
ObservationRegistry observationRegistry = context.getBean(ObservationRegistry.class);
// This is allowed by ObservationPredicates.customPredicate
Observation observation = Observation.start("observation1", observationRegistry);
assertThat(observation).isNotEqualTo(Observation.NOOP);
assertThat(observation.isNoop()).isFalse();
observation.stop();
// This isn't allowed by ObservationPredicates.customPredicate
observation = Observation.start("observation2", observationRegistry);
assertThat(observation).isEqualTo(Observation.NOOP);
assertThat(observation.isNoop()).isTrue();
observation.stop();
});
}
@@ -150,7 +150,7 @@ class ObservationAutoConfigurationTests {
this.contextRunner.run((context) -> {
ObservationRegistry observationRegistry = context.getBean(ObservationRegistry.class);
Observation observation = Observation.start("spring.security.filterchains", observationRegistry);
assertThat(observation).isNotEqualTo(Observation.NOOP);
assertThat(observation.isNoop()).isFalse();
observation.stop();
});
}
@@ -160,7 +160,7 @@ class ObservationAutoConfigurationTests {
this.contextRunner.withPropertyValues("management.observations.enable.spring.security=false").run((context) -> {
ObservationRegistry observationRegistry = context.getBean(ObservationRegistry.class);
Observation observation = Observation.start("spring.security.filterchains", observationRegistry);
assertThat(observation).isEqualTo(Observation.NOOP);
assertThat(observation.isNoop()).isTrue();
observation.stop();
});
}