spring/spring-boot
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-boot.git synced 2026-09-17 12:09:16 +00:00
Code Issues Projects Releases Wiki Activity

Polish "Honor gRPC overall health setting"

Browse Source 
See gh-50799
This commit is contained in:
Stéphane Nicoll
2026-07-23 14:17:38 +02:00
parent da318b2540
commit e2b4c93c57
2 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
module/spring-boot-grpc-server/src/main/java/org/springframework/boot/grpc/server/autoconfigure/health/AutoConfiguredHealthCheckedGrpcComponents.java
+2 -4
View File
@@ -68,10 +68,8 @@ class AutoConfiguredHealthCheckedGrpcComponents implements HealthCheckedGrpcComp
() -> StatusAggregator.of(properties.getStatus().getOrder()));
StatusMapper statusMapper = getNonQualifiedBean(beanFactory, StatusMapper.class,
() -> StatusMapper.of(properties.getStatus().getMapping()));
this.server = (properties.isIncludeOverallHealth())
? new AutoConfiguredHealthCheckedGrpcComponent(HealthContributorMembership.always(), statusAggregator,
statusMapper)
: null;
this.server = (properties.isIncludeOverallHealth()) ? new AutoConfiguredHealthCheckedGrpcComponent(
HealthContributorMembership.always(), statusAggregator, statusMapper) : null;
this.services = createServices(properties.getService(), beanFactory, statusAggregator, statusMapper);
}
module/spring-boot-grpc-server/src/test/java/org/springframework/boot/grpc/server/autoconfigure/health/GrpcServerHealthAutoConfigurationTests.java
+7 -6
View File
@@ -304,12 +304,13 @@ class GrpcServerHealthAutoConfigurationTests {
@Test
void whenIncludeOverallHealthIsFalseDoesNotReportOverallHealth() {
this.contextRunner.withPropertyValues("spring.grpc.server.health.include-overall-health=false").run((context) -> {
GrpcServerHealth serverHealth = context.getBean(GrpcServerHealth.class);
Map<String, ServingStatus> result = new LinkedHashMap<>();
serverHealth.update(result::put);
assertThat(result).isEmpty();
});
this.contextRunner.withPropertyValues("spring.grpc.server.health.include-overall-health=false")
.run((context) -> {
GrpcServerHealth serverHealth = context.getBean(GrpcServerHealth.class);
Map<String, ServingStatus> result = new LinkedHashMap<>();
serverHealth.update(result::put);
assertThat(result).isEmpty();
});
}
@Test