Merge branch '3.5.x' into 4.0.x

Closes gh-50609
This commit is contained in:
Stéphane Nicoll
2026-05-29 11:13:43 +02:00
2 changed files with 83 additions and 5 deletions
@@ -76,11 +76,13 @@ public class SslServerCustomizer implements NettyServerCustomizer {
}
private void applySecurity(SslContextSpec spec) {
spec.sslContext(this.sslProvider.getSslContext()).setSniAsyncMappings((serverName, promise) -> {
SslProvider provider = (serverName != null) ? this.serverNameSslProviders.get(serverName)
: this.sslProvider;
return promise.setSuccess(provider);
});
spec.sslContext(this.sslProvider.getSslContext())
.setSniAsyncMappings((serverName, promise) -> promise.setSuccess(getSslProvider(serverName)));
}
SslProvider getSslProvider(@Nullable String serverName) {
return (serverName != null) ? this.serverNameSslProviders.getOrDefault(serverName, this.sslProvider)
: this.sslProvider;
}
void updateSslBundle(@Nullable String serverName, SslBundle sslBundle) {
@@ -0,0 +1,76 @@
/*
* Copyright 2012-present the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.boot.reactor.netty;
import java.util.Collections;
import java.util.Map;
import org.junit.jupiter.api.Test;
import reactor.netty.tcp.SslProvider;
import org.springframework.boot.ssl.SslBundle;
import org.springframework.boot.ssl.pem.PemSslStoreBundle;
import org.springframework.boot.ssl.pem.PemSslStoreDetails;
import org.springframework.boot.testsupport.classpath.resources.WithPackageResources;
import org.springframework.boot.web.server.Ssl;
import static org.assertj.core.api.Assertions.assertThat;
/**
* Tests for {@link SslServerCustomizer}.
*
* @author Daeho Kwon
*/
class SslServerCustomizerTests {
@Test
@WithPackageResources({ "1.key", "1.crt", "2.key", "2.crt" })
void getSslProviderReturnsMappedProviderForKnownServerName() {
SslBundle defaultBundle = createBundle("1.key", "1.crt");
SslBundle mappedBundle = createBundle("2.key", "2.crt");
SslServerCustomizer customizer = new SslServerCustomizer(null, Ssl.ClientAuth.NONE, defaultBundle,
Map.of("mapped.example", mappedBundle));
SslProvider mapped = customizer.getSslProvider("mapped.example");
assertThat(mapped).isNotNull().isNotSameAs(customizer.getSslProvider(null));
}
@Test
@WithPackageResources({ "1.key", "1.crt", "2.key", "2.crt" })
void getSslProviderFallsBackToDefaultWhenServerNameIsUnmapped() {
SslBundle defaultBundle = createBundle("1.key", "1.crt");
SslBundle mappedBundle = createBundle("2.key", "2.crt");
SslServerCustomizer customizer = new SslServerCustomizer(null, Ssl.ClientAuth.NONE, defaultBundle,
Map.of("mapped.example", mappedBundle));
assertThat(customizer.getSslProvider("unmapped.example")).isSameAs(customizer.getSslProvider(null));
}
@Test
@WithPackageResources({ "1.key", "1.crt" })
@SuppressWarnings("NullAway") // Test null check
void getSslProviderReturnsDefaultWhenServerNameIsNull() {
SslBundle defaultBundle = createBundle("1.key", "1.crt");
SslServerCustomizer customizer = new SslServerCustomizer(null, Ssl.ClientAuth.NONE, defaultBundle,
Collections.emptyMap());
assertThat(customizer.getSslProvider(null)).isNotNull();
}
private static SslBundle createBundle(String key, String certificate) {
return SslBundle.of(new PemSslStoreBundle(
new PemSslStoreDetails(null, "classpath:" + certificate, "classpath:" + key), null));
}
}