Several tests called AssertJ's assertThat without chaining an assertion,
or chained withFailMessage after the assertion had already run, so they
verified nothing. Found with OpenRewrite's FindIgnoredCheckReturnValue.
See gh-52045
Signed-off-by: Tim te Beek <tim@moderne.io>
When the test context framework pauses a cached context, the logging
lifecycle's stop() cleans up the logging system. With Logback this
uninstalls the JUL bridge handler for the whole JVM and nothing
reinstalls it when the context is restarted, so JUL output is lost
in later tests that reuse the context.
This commit makes the lifecycle non-pauseable so that cleanup only
happens on close, as it already does for the web server lifecycles.
See gh-51959
Signed-off-by: Raphael Vullriede <raphael@osslabz.net>
Closes gh-51957
* grpc-service-config-duration:
Polish "Zero-pad nanos in gRPC service config durations"
Zero-pad nanos in gRPC service config durations
Remove the unmatched opening brace from the Web MVC dependency so the
example can be evaluated as a Gradle build script.
See gh-51956
Signed-off-by: sunghwan kwon <sunghwan.ian.kwon@gmail.com>
MongoDockerComposeConnectionDetailsFactory built the connection string
by appending MONGO_INITDB_ROOT_USERNAME and MONGO_INITDB_ROOT_PASSWORD
without encoding them. The mongo image accepts any password, but a
value containing a reserved character such as '@', ':' or '/' produced
an invalid connection string and the application failed to start.
Percent-encode the username and password, as
PropertiesMongoConnectionDetails already does. Spaces are encoded as
%20 because the MongoDB driver does not decode '+' to a space.
See gh-51939
Signed-off-by: lavinhoque33 <caspianprince33@yahoo.com>
Closes gh-52037
* dependabot/github_actions/gradle/actions/setup-gradle-6.4.0:
Polish "Bump gradle/actions/setup-gradle from 6.3.0 to 6.4.0"
Bump gradle/actions/setup-gradle from 6.3.0 to 6.4.0
checkAntoraJavadocMacros was never wired into the build and its
classpath, implementation, is not resolvable. Broken javadoc: links
went unnoticed.
Use runtimeClasspath, make antora depend on the check and add lombok,
which the docs link to. Also fix rejection of no-argument method
links and the method signature in failure messages.
Closes gh-52051
Stéphane Nicoll
Tim te Beek
Raphael Vullriede
Iain
sunghwan kwon
lavinhoque33
dependabot[bot]
Moritz Halbritter
Andy Wilkinson