spring/spring-framework
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-framework.git synced 2026-10-09 08:40:39 +00:00
Code Issues Projects Releases Wiki Activity

Log broker availability events as String messages

Browse Source 
Prior to this commit, AbstractBrokerMessageHandler logged the
BrokerAvailabilityEvent object directly at INFO level. With a structured
JSON logging layout, the event could be serialized as an object rather
than via toString(), causing the layout to traverse the event source
(a SimpleBrokerMessageHandler) object graph. That graph contains a
cyclic reference through the client inbound channel executor's thread
factory, which fails serialization at the maximum nesting depth.

This commit logs the event's toString() representation instead, keeping
the same operational signal while preventing structured logging layouts
from traversing framework internals.

Signed-off-by: kodacme <kodac.saito@kodac.me>
This commit is contained in:
kodacme
2026-09-04 16:37:30 +02:00
committed by Brian Clozel
parent 8c151f5887
commit 2d478f7d9b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spring-messaging/src/main/java/org/springframework/messaging/simp/broker/AbstractBrokerMessageHandler.java
+2 -2
View File
@@ -334,7 +334,7 @@ public abstract class AbstractBrokerMessageHandler
boolean shouldPublish = this.brokerAvailable.compareAndSet(false, true);
if (this.eventPublisher != null && shouldPublish) {
if (logger.isInfoEnabled()) {
logger.info(this.availableEvent);
logger.info(this.availableEvent.toString());
}
this.eventPublisher.publishEvent(this.availableEvent);
}
@@ -344,7 +344,7 @@ public abstract class AbstractBrokerMessageHandler
boolean shouldPublish = this.brokerAvailable.compareAndSet(true, false);
if (this.eventPublisher != null && shouldPublish) {
if (logger.isInfoEnabled()) {
logger.info(this.notAvailableEvent);
logger.info(this.notAvailableEvent.toString());
}
this.eventPublisher.publishEvent(this.notAvailableEvent);
}