spring/spring-framework
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-framework.git synced 2026-09-17 16:39:29 +00:00
Code Issues Projects Releases Wiki Activity

Add missing tests for WebRequestDataBinder

Browse Source 
See gh-36625
This commit is contained in:
Sam Brannen
2026-04-16 16:33:43 +02:00
parent 61bd79017f
commit 63817ce202
1 changed files with 39 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spring-web/src/test/java/org/springframework/web/bind/support/WebRequestDataBinderTests.java
+39 -3
View File
@@ -344,6 +344,41 @@ class WebRequestDataBinderTests {
assertThat(tb.getCountry()).isNull();
}
@Test
void shouldNotTriggerBindingWhenFieldIsNotAllowedWithEmptyArrayIndex() {
TestBean tb = new TestBean();
WebRequestDataBinder binder = new WebRequestDataBinder(tb);
binder.setAllowedFields("name");
MockHttpServletRequest request = new MockHttpServletRequest();
request.addParameter("name", "spring");
request.addParameter(prefix + "stringArray[]", "ONE");
request.addParameter(prefix + "stringArray[]", "TWO");
binder.bind(new ServletWebRequest(request));
assertThat(tb.getName()).isEqualTo("spring");
assertThat(tb.getStringArray()).isNull();
}
@ParameterizedTest
@ValueSource(strings = { "stringArray*", "stringArray[]" })
void shouldNotTriggerBindingWhenFieldIsDisallowedWithEmptyArrayIndex(String disallowedField) {
TestBean tb = new TestBean();
WebRequestDataBinder binder = new WebRequestDataBinder(tb);
binder.setDisallowedFields(disallowedField);
MockHttpServletRequest request = new MockHttpServletRequest();
request.addParameter("name", "spring");
request.addParameter(prefix + "stringArray[]", "ONE");
request.addParameter(prefix + "stringArray[]", "TWO");
binder.bind(new ServletWebRequest(request));
assertThat(tb.getName()).isEqualTo("spring");
assertThat(tb.getStringArray()).isNull();
}
@Test
void shouldNotTriggerAutoGrowWhenFieldIsNotAllowed() {
TestBean tb = new TestBean();
@@ -361,13 +396,14 @@ class WebRequestDataBinderTests {
assertThat(tb.getSomeMap()).isNull();
}
@Test
void shouldNotTriggerAutoGrowWhenFieldIsDisallowed() {
@ParameterizedTest
@ValueSource(strings = { "someMap*", "someMap[*]", "someMap[key1]" })
void shouldNotTriggerAutoGrowWhenFieldIsDisallowed(String disallowedField) {
TestBean tb = new TestBean();
tb.setSomeMap(null);
WebRequestDataBinder binder = new WebRequestDataBinder(tb);
binder.setDisallowedFields("someMap[key1]");
binder.setDisallowedFields(disallowedField);
MockHttpServletRequest request = new MockHttpServletRequest();
request.addParameter("name", "spring");