spring/spring-framework
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-framework.git synced 2026-10-06 15:09:34 +00:00
Code Issues Projects Releases Wiki Activity

Lower bad requests to DEBUG level in AbstractHandshakeHandler

Browse Source 
Closes gh-35930
This commit is contained in:
rstoyanchev
2025-12-04 09:24:11 +00:00
parent 5b4728f0bf
commit 8803d3c5dc
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spring-websocket/src/main/java/org/springframework/web/socket/server/support/AbstractHandshakeHandler.java
+10 -10
View File
@@ -218,8 +218,8 @@ public abstract class AbstractHandshakeHandler implements HandshakeHandler, Life
if (HttpMethod.GET != httpMethod && !CONNECT_METHOD.equals(httpMethod)) {
response.setStatusCode(HttpStatus.METHOD_NOT_ALLOWED);
response.getHeaders().setAllow(Set.of(HttpMethod.GET, CONNECT_METHOD));
if (logger.isErrorEnabled()) {
logger.error("Handshake failed due to unexpected HTTP method: " + httpMethod);
if (logger.isDebugEnabled()) {
logger.debug("Handshake failed due to unexpected HTTP method: " + httpMethod);
}
return false;
}
@@ -235,8 +235,8 @@ public abstract class AbstractHandshakeHandler implements HandshakeHandler, Life
}
String key = headers.getSecWebSocketKey();
if (key == null) {
if (logger.isErrorEnabled()) {
logger.error("Missing \"Sec-WebSocket-Key\" header");
if (logger.isDebugEnabled()) {
logger.debug("Missing \"Sec-WebSocket-Key\" header");
}
response.setStatusCode(HttpStatus.BAD_REQUEST);
return false;
@@ -270,8 +270,8 @@ public abstract class AbstractHandshakeHandler implements HandshakeHandler, Life
}
protected void handleInvalidUpgradeHeader(ServerHttpRequest request, ServerHttpResponse response) throws IOException {
if (logger.isErrorEnabled()) {
logger.error(LogFormatUtils.formatValue(
if (logger.isDebugEnabled()) {
logger.debug(LogFormatUtils.formatValue(
"Handshake failed due to invalid Upgrade header: " + request.getHeaders().getUpgrade(), -1, true));
}
response.setStatusCode(HttpStatus.BAD_REQUEST);
@@ -279,8 +279,8 @@ public abstract class AbstractHandshakeHandler implements HandshakeHandler, Life
}
protected void handleInvalidConnectHeader(ServerHttpRequest request, ServerHttpResponse response) throws IOException {
if (logger.isErrorEnabled()) {
logger.error(LogFormatUtils.formatValue(
if (logger.isDebugEnabled()) {
logger.debug(LogFormatUtils.formatValue(
"Handshake failed due to invalid Connection header" + request.getHeaders().getConnection(), -1, true));
}
response.setStatusCode(HttpStatus.BAD_REQUEST);
@@ -303,9 +303,9 @@ public abstract class AbstractHandshakeHandler implements HandshakeHandler, Life
}
protected void handleWebSocketVersionNotSupported(ServerHttpRequest request, ServerHttpResponse response) {
if (logger.isErrorEnabled()) {
if (logger.isDebugEnabled()) {
String version = request.getHeaders().getFirst(WebSocketHttpHeaders.SEC_WEBSOCKET_VERSION);
logger.error(LogFormatUtils.formatValue(
logger.debug(LogFormatUtils.formatValue(
"Handshake failed due to unsupported WebSocket version: " + version +
". Supported versions: " + Arrays.toString(getSupportedVersions()), -1, true));
}