spring/spring-framework
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-framework.git synced 2026-09-17 16:39:29 +00:00
Code Issues Projects Releases Wiki Activity

Update MockCookie#parse(String) validation to align with Javadoc

Browse Source 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
This commit is contained in:
Tran Ngoc Nhan
2026-08-13 12:38:02 +02:00
committed by GitHub
parent 68e6acd37e
commit 8b894933ae
3 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spring-test/src/main/java/org/springframework/mock/web/MockCookie.java
+1 -1
View File
@@ -132,7 +132,7 @@ public class MockCookie extends Cookie {
* @return the created cookie
*/
public static MockCookie parse(String setCookieHeader) {
Assert.notNull(setCookieHeader, "Set-Cookie header must not be null");
Assert.hasText(setCookieHeader, "Set-Cookie header must not be null or empty");
String[] cookieParts = setCookieHeader.split("\\s*=\\s*", 2);
Assert.isTrue(cookieParts.length == 2, () -> "Invalid Set-Cookie header '" + setCookieHeader + "'");
spring-test/src/test/java/org/springframework/mock/web/MockCookieTests.java
+9 -1
View File
@@ -118,7 +118,15 @@ class MockCookieTests {
void parseNullHeader() {
assertThatIllegalArgumentException()
.isThrownBy(() -> MockCookie.parse(null))
.withMessageContaining("Set-Cookie header must not be null");
.withMessageContaining("Set-Cookie header must not be null or empty");
}
@ParameterizedTest
@ValueSource(strings = {"", " "})
void parseEmptyHeader(String header) {
assertThatIllegalArgumentException()
.isThrownBy(() -> MockCookie.parse(header))
.withMessageContaining("Set-Cookie header must not be null or empty");
}
@Test
spring-web/src/testFixtures/java/org/springframework/web/testfixture/servlet/MockCookie.java
+1 -1
View File
@@ -132,7 +132,7 @@ public class MockCookie extends Cookie {
* @return the created cookie
*/
public static MockCookie parse(String setCookieHeader) {
Assert.notNull(setCookieHeader, "Set-Cookie header must not be null");
Assert.hasText(setCookieHeader, "Set-Cookie header must not be null or empty");
String[] cookieParts = setCookieHeader.split("\\s*=\\s*", 2);
Assert.isTrue(cookieParts.length == 2, () -> "Invalid Set-Cookie header '" + setCookieHeader + "'");