fixed issue #1168, support filter with compareTableMetaDbAndMemory
This commit is contained in:
+14
-6
@@ -76,7 +76,7 @@ public class DatabaseTableMeta implements TableMetaTSDB {
|
||||
private int snapshotInterval = 24;
|
||||
private int snapshotExpire = 360;
|
||||
private ScheduledFuture<?> scheduleSnapshotFuture;
|
||||
|
||||
|
||||
public DatabaseTableMeta(){
|
||||
|
||||
}
|
||||
@@ -207,8 +207,8 @@ public class DatabaseTableMeta implements TableMetaTSDB {
|
||||
packet = connection.query("show full tables from `" + schema + "` where Table_type = 'BASE TABLE'");
|
||||
List<String> tables = new ArrayList<String>();
|
||||
for (String table : packet.getFieldValues()) {
|
||||
if("BASE TABLE".equalsIgnoreCase(table)){
|
||||
continue;
|
||||
if ("BASE TABLE".equalsIgnoreCase(table)) {
|
||||
continue;
|
||||
}
|
||||
String fullName = schema + "." + table;
|
||||
if (blackFilter == null || !blackFilter.filter(fullName)) {
|
||||
@@ -310,11 +310,19 @@ public class DatabaseTableMeta implements TableMetaTSDB {
|
||||
boolean compareAll = true;
|
||||
for (Schema schema : tmpMemoryTableMeta.getRepository().getSchemas()) {
|
||||
for (String table : schema.showTables()) {
|
||||
if (!compareTableMetaDbAndMemory(connection, tmpMemoryTableMeta, schema.getName(), table)) {
|
||||
compareAll = false;
|
||||
String fullName = schema + "." + table;
|
||||
if (blackFilter == null || !blackFilter.filter(fullName)) {
|
||||
if (filter == null || filter.filter(fullName)) {
|
||||
// issue : https://github.com/alibaba/canal/issues/1168
|
||||
// 在生成snapshot时重新过滤一遍
|
||||
if (!compareTableMetaDbAndMemory(connection, tmpMemoryTableMeta, schema.getName(), table)) {
|
||||
compareAll = false;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (compareAll) {
|
||||
Map<String, String> content = new HashMap<String, String>();
|
||||
content.put("destination", destination);
|
||||
@@ -513,7 +521,7 @@ public class DatabaseTableMeta implements TableMetaTSDB {
|
||||
String sign = sourceField.isUnsigned() ? "unsigned" : "signed";
|
||||
String sourceColumnType = StringUtils.removeEndIgnoreCase(sourceField.getColumnType(), sign).trim();
|
||||
String targetColumnType = StringUtils.removeEndIgnoreCase(targetField.getColumnType(), sign).trim();
|
||||
|
||||
|
||||
boolean columnTypeCompare = false;
|
||||
columnTypeCompare |= StringUtils.containsIgnoreCase(sourceColumnType, targetColumnType);
|
||||
columnTypeCompare |= StringUtils.containsIgnoreCase(targetColumnType, sourceColumnType);
|
||||
|
||||
Reference in New Issue
Block a user